Extract move method

This commit is contained in:
Philipp Lang 2021-09-17 11:31:44 +00:00
parent 0d055c1edf
commit c76eccde13
3 changed files with 13 additions and 10 deletions

View File

@ -2,6 +2,8 @@
namespace Aweos\Resizer\Compressors; namespace Aweos\Resizer\Compressors;
use Storage;
abstract class Compressor abstract class Compressor
{ {
@ -24,4 +26,13 @@ abstract class Compressor
'.'.$this->getExtension(); '.'.$this->getExtension();
} }
public function moveTo(string $source, string $destination): void
{
if (Storage::exists($destination)) {
Storage::delete($destination);
}
Storage::move($source, $destination);
}
} }

View File

@ -51,11 +51,7 @@ class JpgCompressor extends Compressor {
$destHeight. $destHeight.
'.jpg'; '.jpg';
if (Storage::exists($versionFilename)) { $this->moveTo($temp, $versionFilename);
Storage::delete($versionFilename);
}
Storage::move($temp, $versionFilename);
} }
} }

View File

@ -45,11 +45,7 @@ class PngCompressor extends Compressor {
$versionFilename = $destination.'/'.$this->versionFilename($source, $destWidth, $destHeight); $versionFilename = $destination.'/'.$this->versionFilename($source, $destWidth, $destHeight);
if (Storage::exists($versionFilename)) { $this->moveTo($temp, $versionFilename);
Storage::delete($versionFilename);
}
Storage::move($temp, $versionFilename);
} }
} }