From 026e7674dd1bb1a6ef85c261f32009f55ed6c1ee Mon Sep 17 00:00:00 2001
From: Philipp Lang <privat@zoomyboy.de>
Date: Wed, 18 Oct 2023 18:14:07 +0200
Subject: [PATCH] Lint

---
 app/Course/Actions/CourseIndexAction.php    |  4 ++--
 app/Course/Actions/CourseUpdateAction.php   |  6 +-----
 app/Payment/Actions/PaymentStoreAction.php  |  6 ++++--
 app/Payment/Actions/PaymentUpdateAction.php |  6 ++++--
 phpstan.neon                                | 10 ----------
 5 files changed, 11 insertions(+), 21 deletions(-)

diff --git a/app/Course/Actions/CourseIndexAction.php b/app/Course/Actions/CourseIndexAction.php
index f1188634..a71f3173 100644
--- a/app/Course/Actions/CourseIndexAction.php
+++ b/app/Course/Actions/CourseIndexAction.php
@@ -2,7 +2,7 @@
 
 namespace App\Course\Actions;
 
-use App\Course\Models\Course;
+use App\Course\Models\CourseMember;
 use App\Course\Resources\CourseMemberResource;
 use App\Member\Member;
 use Illuminate\Database\Eloquent\Collection;
@@ -14,7 +14,7 @@ class CourseIndexAction
     use AsAction;
 
     /**
-     * @return Collection<int, Course>
+     * @return Collection<int, CourseMember>
      */
     public function handle(Member $member): Collection
     {
diff --git a/app/Course/Actions/CourseUpdateAction.php b/app/Course/Actions/CourseUpdateAction.php
index ee0e35c0..0ae93df1 100644
--- a/app/Course/Actions/CourseUpdateAction.php
+++ b/app/Course/Actions/CourseUpdateAction.php
@@ -4,15 +4,11 @@ namespace App\Course\Actions;
 
 use App\Course\Models\Course;
 use App\Course\Models\CourseMember;
-use App\Course\Resources\CourseMemberResource;
 use App\Lib\JobMiddleware\JobChannels;
 use App\Lib\JobMiddleware\WithJobState;
 use App\Lib\Queue\TracksJob;
-use App\Member\Member;
 use App\Setting\NamiSettings;
-use Illuminate\Database\Eloquent\Collection;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Http\Resources\Json\AnonymousResourceCollection;
 use Lorisleiva\Actions\ActionRequest;
 use Lorisleiva\Actions\Concerns\AsAction;
 
@@ -22,7 +18,7 @@ class CourseUpdateAction
     use TracksJob;
 
     /**
-     * @return Collection<int, Course>
+     * @param array<string, string> $attributes
      */
     public function handle(CourseMember $course, array $attributes): void
     {
diff --git a/app/Payment/Actions/PaymentStoreAction.php b/app/Payment/Actions/PaymentStoreAction.php
index 93e2fba2..c9ab1aff 100644
--- a/app/Payment/Actions/PaymentStoreAction.php
+++ b/app/Payment/Actions/PaymentStoreAction.php
@@ -7,7 +7,6 @@ use App\Lib\JobMiddleware\WithJobState;
 use App\Lib\Queue\TracksJob;
 use App\Member\Member;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Validation\Rules\In;
 use Lorisleiva\Actions\ActionRequest;
 use Lorisleiva\Actions\Concerns\AsAction;
 
@@ -16,13 +15,16 @@ class PaymentStoreAction
     use AsAction;
     use TracksJob;
 
+    /**
+     * @param array<string, string> $attributes
+     */
     public function handle(Member $member, array $attributes): void
     {
         $member->createPayment($attributes);
     }
 
     /**
-     * @return array<string, array<int, string|In>>
+     * @return array<string, string>
      */
     public function rules(): array
     {
diff --git a/app/Payment/Actions/PaymentUpdateAction.php b/app/Payment/Actions/PaymentUpdateAction.php
index 6f5ab70e..9c6bd95c 100644
--- a/app/Payment/Actions/PaymentUpdateAction.php
+++ b/app/Payment/Actions/PaymentUpdateAction.php
@@ -7,7 +7,6 @@ use App\Lib\JobMiddleware\WithJobState;
 use App\Lib\Queue\TracksJob;
 use App\Payment\Payment;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Validation\Rules\In;
 use Lorisleiva\Actions\ActionRequest;
 use Lorisleiva\Actions\Concerns\AsAction;
 
@@ -16,13 +15,16 @@ class PaymentUpdateAction
     use AsAction;
     use TracksJob;
 
+    /**
+     * @param array<string, string> $attributes
+     */
     public function handle(Payment $payment, array $attributes): void
     {
         $payment->update($attributes);
     }
 
     /**
-     * @return array<string, array<int, string|In>>
+     * @return array<string, string>
      */
     public function rules(): array
     {
diff --git a/phpstan.neon b/phpstan.neon
index 879129b8..a15a968c 100644
--- a/phpstan.neon
+++ b/phpstan.neon
@@ -28,16 +28,6 @@ parameters:
             count: 1
             path: app/Activity.php
 
-        -
-            message: "#^Unable to resolve the template type TKey in call to function collect$#"
-            count: 1
-            path: app/Course/Requests/StoreRequest.php
-
-        -
-            message: "#^Unable to resolve the template type TValue in call to function collect$#"
-            count: 1
-            path: app/Course/Requests/StoreRequest.php
-
         -
             message: "#^Method App\\\\Dav\\\\AddressBookBackend\\:\\:getCard\\(\\) should return M of array\\{lastmodified\\: int, etag\\: string, uri\\: string, id\\: int, size\\: int\\} but returns false\\.$#"
             count: 1