Add Member filter to prevention settings

This commit is contained in:
philipp lang 2025-05-30 00:32:34 +02:00
parent 3182dc7edd
commit 363c4360b8
6 changed files with 36 additions and 8 deletions

View File

@ -4,6 +4,7 @@ namespace App\Prevention\Actions;
use App\Lib\Editor\EditorData; use App\Lib\Editor\EditorData;
use App\Lib\Events\Succeeded; use App\Lib\Events\Succeeded;
use App\Member\FilterScope;
use App\Prevention\PreventionSettings; use App\Prevention\PreventionSettings;
use Lorisleiva\Actions\ActionRequest; use Lorisleiva\Actions\ActionRequest;
use Lorisleiva\Actions\Concerns\AsAction; use Lorisleiva\Actions\Concerns\AsAction;
@ -34,6 +35,7 @@ class SettingStoreAction
$settings->weeks = $request->weeks; $settings->weeks = $request->weeks;
$settings->freshRememberInterval = $request->freshRememberInterval; $settings->freshRememberInterval = $request->freshRememberInterval;
$settings->active = $request->active; $settings->active = $request->active;
$settings->yearlyMemberFilter = FilterScope::from($request->yearlyMemberFilter);
$settings->save(); $settings->save();
Succeeded::message('Einstellungen gespeichert.')->dispatch(); Succeeded::message('Einstellungen gespeichert.')->dispatch();

View File

@ -3,6 +3,7 @@
namespace App\Prevention; namespace App\Prevention;
use App\Lib\Editor\EditorData; use App\Lib\Editor\EditorData;
use App\Member\FilterScope;
use App\Setting\LocalSettings; use App\Setting\LocalSettings;
class PreventionSettings extends LocalSettings class PreventionSettings extends LocalSettings
@ -13,6 +14,7 @@ class PreventionSettings extends LocalSettings
public int $weeks; public int $weeks;
public int $freshRememberInterval; public int $freshRememberInterval;
public bool $active; public bool $active;
public FilterScope $yearlyMemberFilter;
public static function group(): string public static function group(): string
{ {

View File

@ -1,5 +1,6 @@
<?php <?php
use App\Member\FilterScope;
use Spatie\LaravelSettings\Migrations\SettingsMigration; use Spatie\LaravelSettings\Migrations\SettingsMigration;
return new class extends SettingsMigration return new class extends SettingsMigration
@ -10,5 +11,6 @@ return new class extends SettingsMigration
$this->migrator->add('prevention.weeks', 8); $this->migrator->add('prevention.weeks', 8);
$this->migrator->add('prevention.freshRememberInterval', 12); $this->migrator->add('prevention.freshRememberInterval', 12);
$this->migrator->add('prevention.active', false); $this->migrator->add('prevention.active', false);
$this->migrator->add('prevention.yearlyMemberFilter', FilterScope::from([])->toArray());
} }
}; };

View File

@ -19,9 +19,7 @@
</ui-popup> </ui-popup>
<page-filter> <page-filter>
<template #fields> <template #fields>
<suspense> <member-filter-fields :model-value="filter" @update:model-value="setFilterObject($event)" />
<member-filter-fields :model-value="filter" @update:model-value="setFilterObject($event)" />
</suspense>
</template> </template>
<template #buttons> <template #buttons>
<f-text id="search" :model-value="filter.search" label="Suchen …" size="sm" @update:model-value="setFilterObject({...filter, search: $event})"></f-text> <f-text id="search" :model-value="filter.search" label="Suchen …" size="sm" @update:model-value="setFilterObject({...filter, search: $event})"></f-text>

View File

@ -20,6 +20,7 @@
<f-text id="fresh_remember_interval" v-model="data.freshRememberInterval" label="Bei Ablauf alle X Wochen erinnern" type="number" /> <f-text id="fresh_remember_interval" v-model="data.freshRememberInterval" label="Bei Ablauf alle X Wochen erinnern" type="number" />
</div> </div>
<f-editor v-if="active === 1" id="yearlymail" v-model="data.yearlymail" label="Jährliche Präventions-Erinnerung"></f-editor> <f-editor v-if="active === 1" id="yearlymail" v-model="data.yearlymail" label="Jährliche Präventions-Erinnerung"></f-editor>
<f-member-filter id="yearly_member_filter" v-model="data.yearlyMemberFilter" label="nur für folgende Mitglieder erlauben" />
</div> </div>
</form> </form>
</setting-layout> </setting-layout>

View File

@ -2,6 +2,7 @@
namespace Tests\Feature\Prevention; namespace Tests\Feature\Prevention;
use App\Member\FilterScope;
use App\Prevention\PreventionSettings; use App\Prevention\PreventionSettings;
use Illuminate\Foundation\Testing\DatabaseTransactions; use Illuminate\Foundation\Testing\DatabaseTransactions;
use Tests\RequestFactories\EditorRequestFactory; use Tests\RequestFactories\EditorRequestFactory;
@ -20,25 +21,47 @@ it('receives settings', function () {
$text = EditorRequestFactory::new()->text(50, 'lorem ipsum')->toData(); $text = EditorRequestFactory::new()->text(50, 'lorem ipsum')->toData();
$yearlyMail = EditorRequestFactory::new()->text(50, 'lala dd')->toData(); $yearlyMail = EditorRequestFactory::new()->text(50, 'lala dd')->toData();
app(PreventionSettings::class)->fill(['formmail' => $text, 'yearlymail' => $yearlyMail, 'weeks' => 9, 'freshRememberInterval' => 11, 'active' => true])->save(); app(PreventionSettings::class)->fill([
'formmail' => $text,
'yearlymail' => $yearlyMail,
'weeks' => 9,
'freshRememberInterval' => 11,
'active' => true,
'yearlyMemberFilter' => FilterScope::from([
'memberships' => [['group_ids' => [33]]],
'search' => 'searchstring',
]),
])->save();
test()->get('/api/prevention') test()->get('/api/prevention')
->assertJsonPath('data.formmail.blocks.0.data.text', 'lorem ipsum') ->assertJsonPath('data.formmail.blocks.0.data.text', 'lorem ipsum')
->assertJsonPath('data.yearlymail.blocks.0.data.text', 'lala dd') ->assertJsonPath('data.yearlymail.blocks.0.data.text', 'lala dd')
->assertJsonPath('data.weeks', '9') ->assertJsonPath('data.weeks', '9')
->assertJsonPath('data.active', true) ->assertJsonPath('data.active', true)
->assertJsonPath('data.freshRememberInterval', '11'); ->assertJsonPath('data.freshRememberInterval', '11')
->assertJsonPath('data.yearlyMemberFilter.search', 'searchstring')
->assertJsonPath('data.yearlyMemberFilter.memberships.0.group_ids.0', 33);
}); });
it('testItStoresSettings', function () { it('testItStoresSettings', function () {
test()->login()->loginNami(); test()->login()->loginNami();
$formmail = EditorRequestFactory::new()->text(50, 'new lorem')->create(); test()->post('/api/prevention', [
$yearlyMail = EditorRequestFactory::new()->text(50, 'lala dd')->create(); 'formmail' => EditorRequestFactory::new()->text(50, 'new lorem')->create(),
test()->post('/api/prevention', ['formmail' => $formmail, 'yearlymail' => $yearlyMail, 'weeks' => 9, 'freshRememberInterval' => 11, 'active' => true])->assertOk(); 'yearlymail' => EditorRequestFactory::new()->text(50, 'lala dd')->create(),
'weeks' => 9,
'freshRememberInterval' => 11,
'active' => true,
'yearlyMemberFilter' => [
'memberships' => [['group_ids' => 33]],
'search' => 'searchstring',
],
])->assertOk();
test()->assertTrue(app(PreventionSettings::class)->formmail->hasAll(['new lorem'])); test()->assertTrue(app(PreventionSettings::class)->formmail->hasAll(['new lorem']));
test()->assertTrue(app(PreventionSettings::class)->yearlymail->hasAll(['lala dd'])); test()->assertTrue(app(PreventionSettings::class)->yearlymail->hasAll(['lala dd']));
test()->assertEquals(9, app(PreventionSettings::class)->weeks); test()->assertEquals(9, app(PreventionSettings::class)->weeks);
test()->assertEquals(11, app(PreventionSettings::class)->freshRememberInterval); test()->assertEquals(11, app(PreventionSettings::class)->freshRememberInterval);
test()->assertTrue(app(PreventionSettings::class)->active); test()->assertTrue(app(PreventionSettings::class)->active);
test()->assertEquals([['group_ids' => 33]], app(PreventionSettings::class)->yearlyMemberFilter->memberships);
test()->assertEquals('searchstring', app(PreventionSettings::class)->yearlyMemberFilter->search);
}); });