silva
/
adrema
2
1
Fork 0
Code Issues 23 Pull Requests 1 Projects 1 Releases 106 Wiki Activity

Fix: Compile contribution documents without gender

This commit is contained in:
philipp lang 2025-06-23 22:33:18 +02:00
parent b0fd584397
commit 51af9d427e
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Contribution/Data/MemberData.php
View File

@ -47,7 +47,7 @@ class MemberData extends Data
return collect($data)->map(fn ($member) => self::factory()->withoutMagicalCreation()->from([ return collect($data)->map(fn ($member) => self::factory()->withoutMagicalCreation()->from([
...$member, ...$member,
'birthday' => Carbon::parse($member['birthday'])->toAtomString(), 'birthday' => Carbon::parse($member['birthday'])->toAtomString(),
'gender' => Gender::fromString($member['gender']), 'gender' => $member['gender'] ? Gender::fromString($member['gender']) : null,
'isLeader' => $member['is_leader'], 'isLeader' => $member['is_leader'],
])); ]));
} }

22
tests/Feature/Contribution/StoreTest.php
View File

@ -100,6 +100,28 @@ it('testItCompilesContributionDocumentsViaApi', function (string $type, array $b
Tex::assertCompiled($type, fn ($document) => $document->hasAllContent($bodyChecks)); Tex::assertCompiled($type, fn ($document) => $document->hasAllContent($bodyChecks));
})->with('contribution-assertions'); })->with('contribution-assertions');
it('compiles when gender is null', function () {
$this->withoutExceptionHandling();
Tex::spy();
Passport::actingAsClient(Client::factory()->create(), ['contribution-generate']);
$response = $this->postJson('/api/contribution-generate', [
'country' => Country::factory()->create()->id,
'dateFrom' => '1991-06-15',
'dateUntil' => '1991-06-16',
'eventName' => 'Super tolles Lager',
'type' => CitySolingenDocument::class,
'zipLocation' => '42777 SG',
'members' => [
ContributionMemberApiRequestFactory::new()->create(['address' => 'Maxstr 44', 'zip' => '42719', 'firstname' => 'Jane', 'lastname' => 'Muster', 'gender' => null]),
],
]);
$response->assertSessionDoesntHaveErrors();
$response->assertOk();
Tex::assertCompiled(CitySolingenDocument::class, fn () => true);
});
it('testInputShouldBeBase64EncodedJson', function (string $payload) { it('testInputShouldBeBase64EncodedJson', function (string $payload) {
$this->login()->loginNami(); $this->login()->loginNami();