silva
/
adrema
2
1
Fork 0
Code Issues 23 Pull Requests 1 Projects 1 Releases 104 Wiki Activity

Add test for email validation
continuous-integration/drone/push Build is failing Details

This commit is contained in:
philipp lang 2024-04-13 21:57:58 +02:00
parent 5e49e5bd59
commit 56e0223492
3 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Form/Fields/EmailField.php
View File

@ -17,6 +17,6 @@ class EmailField extends TextField
*/
public function getRegistrationRules(Form $form): array
{
return [$this->key => $this->required ? ['required', 'string', 'email'] : ['nullable', 'string']];
return [$this->key => $this->required ? ['required', 'string', 'email'] : ['nullable', 'email', 'string']];
}
}

12
tests/Feature/Form/FormRegisterActionTest.php
View File

@ -254,6 +254,18 @@ class FormRegisterActionTest extends FormTestCase
['vorname' => 5],
['vorname' => 'Vorname der Mutter muss ein String sein.']
];
yield [
$this->emailField('email')->name('Mail')->required(true),
['email' => 'alaaa'],
['email' => 'Mail muss eine gültige E-Mail-Adresse sein.']
];
yield [
$this->emailField('email')->name('Mail')->required(false),
['email' => 'alaaa'],
['email' => 'Mail muss eine gültige E-Mail-Adresse sein.']
];
}
public function testItValidatesGroupFieldWithParentGroupField(): void

8
tests/Lib/CreatesFormFields.php
View File

@ -6,6 +6,7 @@ use App\Form\Fields\CheckboxesField;
use App\Form\Fields\CheckboxField;
use App\Form\Fields\DateField;
use App\Form\Fields\DropdownField;
use App\Form\Fields\EmailField;
use App\Form\Fields\GroupField;
use App\Form\Fields\NamiField;
use App\Form\Fields\RadioField;
@ -26,6 +27,11 @@ trait CreatesFormFields
return FormtemplateFieldRequest::type(TextField::class)->key($key ?? $this->randomKey());
}
protected function emailField(?string $key = null): FormtemplateFieldRequest
{
return FormtemplateFieldRequest::type(EmailField::class)->key($key ?? $this->randomKey());
}
protected function checkboxesField(?string $key = null): FormtemplateFieldRequest
{
return FormtemplateFieldRequest::type(CheckboxesField::class)->key($key ?? $this->randomKey());
@ -63,6 +69,6 @@ trait CreatesFormFields
protected function randomKey(): string
{
return preg_replace('/[\-0-9]/', '', str()->uuid().str()->uuid());
return preg_replace('/[\-0-9]/', '', str()->uuid() . str()->uuid());
}
}