update initializer

app/Initialize/Actions/InitializeAction.php

@@ -45,7 +45,7 @@ class InitializeAction
 
     private Api $api;
 
-    public function handle(int $mglnr, string $password, int $groupId): void
+    public function handle(): void
     {
         foreach ($this->initializers as $initializer) {
             app($initializer)->handle($this->api);
@@ -74,38 +74,33 @@ class InitializeAction
         ];
     }
 
-    public function asController(ActionRequest $request, NamiSettings $settings): RedirectResponse
+    public function asController(ActionRequest $request): RedirectResponse
     {
-        $this->api = Nami::login($request->input('mglnr'), $request->input('password'));
+        $api = Nami::freshLogin($request->input('mglnr'), $request->input('password'));
 
-        if (!$this->api->hasGroup($request->input('group_id'))) {
+        if (!$api->hasGroup($request->input('group_id'))) {
             throw ValidationException::withMessages(['nami' => 'Gruppierung nicht gefunden.']);
         }
 
-        $settings->mglnr = $request->input('mglnr');
+        $this->setApi((int) $request->input('mglnr'), $request->input('password'), (int) $request->input('group_id'));
-        $settings->password = $request->input('password');
+        $this->handle();
-        $settings->default_group_id = $request->input('group_id');
-        $settings->save();
-
-        $this->handle(
-            (int) $request->input('mglnr', 0),
-            (string) $request->input('password', ''),
-            (int) $request->input('group_id', 0)
-        );
 
         return redirect()->route('home')->success('Initialisierung beauftragt. Wir benachrichtigen dich per Mail wenn alles fertig ist.');
     }
 
-    public function asCommand(Command $command, NamiSettings $settings): void
+    public function asCommand(Command $command): void
     {
-        $mglnr = (int) $command->option('mglnr');
+        $this->setApi((int) $command->option('mglnr'), $command->option('password'), (int) $command->option('group'));
-        $password = $command->option('password');
+        $this->handle();
-        $group = (int) $command->option('group');
+    }
-        $this->api = Nami::login($mglnr, $password);
+
+    private function setApi(int $mglnr, string $password, int $groupId): void
+    {
+        $settings = app(NamiSettings::class);
         $settings->mglnr = $mglnr;
         $settings->password = $password;
-        $settings->default_group_id = $group;
+        $settings->default_group_id = $groupId;
         $settings->save();
-        $this->handle((int) $mglnr, (string) $password, (int) $group);
+        $this->api = $settings->login();
     }
 }

packages/laravel-nami

@@ -1 +1 @@
-Subproject commit a41b190cc2509ee940967b6c108a557b0a9c5def
+Subproject commit 75983ebb4bad205629b57e18915b2f15fa38e835

phpstan.neon

@@ -564,11 +564,6 @@ parameters:
             count: 1
             path: tests/Feature/Initialize/InitializeActionTest.php
 
-        -
-            message: "#^Call to an undefined method Mockery\\\\ExpectationInterface\\|Mockery\\\\HigherOrderMessage\\:\\:with\\(\\)\\.$#"
-            count: 1
-            path: tests/Feature/Initialize/InitializeActionTest.php
-
         -
             message: "#^Call to an undefined method Mockery\\\\ExpectationInterface\\|Mockery\\\\HigherOrderMessage\\:\\:once\\(\\)\\.$#"
             count: 2

tests/Feature/Initialize/InitializeActionTest.php

@@ -26,7 +26,7 @@ class InitializeActionTest extends TestCase
     public function testItSetsSettingsBeforeRunningInitializer(): void
     {
         $this->withoutExceptionHandling()->login();
-        InitializeAction::partialMock()->shouldReceive('handle')->with(12345, 'secret', 185)->once()->andReturn(true);
+        InitializeAction::partialMock()->shouldReceive('handle')->andReturn(true);
         Auth::success(12345, 'secret');
         app(GroupFake::class)->fetches(null, [185 => ['name' => 'testgroup']]);