Lint tests

tests/Feature/Member/StoreTest.php

@@ -17,16 +17,13 @@ use App\Region;
 use App\Subactivity;
 use Illuminate\Foundation\Testing\DatabaseTransactions;
 use Tests\Lib\MergesAttributes;
+use Tests\RequestFactories\MemberStoreRequestFactory;
 use Tests\TestCase;
 use Zoomyboy\LaravelNami\Fakes\MemberFake;
 
-class StoreTest extends TestCase
+uses(DatabaseTransactions::class);
-{
-    use DatabaseTransactions;
-    use MergesAttributes;
 
-    public function testItCanStoreAMember(): void
+it('can store a member', function () {
-    {
     app(MemberFake::class)->stores(55, 103);
     Fee::factory()->create();
     $this->withoutExceptionHandling()->login()->loginNami();
@@ -37,13 +34,13 @@ class StoreTest extends TestCase
     $activity = Activity::factory()->inNami(89)->create();
     $subactivity = Subactivity::factory()->inNami(90)->create();
     $subscription = Subscription::factory()->forFee()->create();
-        $confesstion = Confession::factory()->create(['is_null' => true]);
+    Confession::factory()->create(['is_null' => true]);
     PullMemberAction::shouldRun();
     PullMembershipsAction::shouldRun();
 
     $response = $this
         ->from('/member/create')
-            ->post('/member', $this->attributes([
+        ->post('/member', MemberStoreRequestFactory::new()->create([
             'country_id' => $country->id,
             'gender_id' => $gender->id,
             'region_id' => $region->id,
@@ -57,7 +54,6 @@ class StoreTest extends TestCase
         ]))->assertSessionHasNoErrors();
 
     $response->assertRedirect('/member')->assertSessionHasNoErrors();
-        $member = Member::firstWhere('firstname', 'Joe');
     $this->assertDatabaseHas('members', [
         'address' => 'Bavert 50',
         'bill_kind' => 'Post',
@@ -87,10 +83,9 @@ class StoreTest extends TestCase
         'ersteTaetigkeitId' => 89,
         'ersteUntergliederungId' => 90,
     ]);
-    }
+});
 
-    public function testItStoresWiederverwendenFlag(): void
+it('testItStoresWiederverwendenFlag', function () {
-    {
     app(MemberFake::class)->stores(55, 103);
     Fee::factory()->create();
     $this->withoutExceptionHandling()->login()->loginNami();
@@ -103,7 +98,7 @@ class StoreTest extends TestCase
 
     $this
         ->from('/member/create')
-            ->post('/member', $this->attributes([
+        ->post('/member', MemberStoreRequestFactory::new()->create([
             'first_activity_id' => $activity->id,
             'first_subactivity_id' => $subactivity->id,
             'subscription_id' => $subscription->id,
@@ -116,17 +111,16 @@ class StoreTest extends TestCase
     app(MemberFake::class)->assertStored(55, [
         'wiederverwendenFlag' => true,
     ]);
-    }
+});
 
-    public function testItCanStoreAMemberWithoutNami(): void
+it('testItCanStoreAMemberWithoutNami', function () {
-    {
     $this->withoutExceptionHandling()->login()->loginNami();
     $activity = Activity::factory()->create();
     $subactivity = Subactivity::factory()->create();
 
     $response = $this
         ->from('/member/create')
-            ->post('/member', $this->attributes([
+        ->post('/member', MemberStoreRequestFactory::new()->create([
             'first_activity_id' => $activity->id,
             'first_subactivity_id' => $subactivity->id,
             'has_nami' => false,
@@ -137,13 +131,12 @@ class StoreTest extends TestCase
         'nami_id' => null,
     ]);
     NamiPutMemberAction::spy()->shouldNotHaveReceived('handle');
-    }
+});
 
-    public function testItUpdatesPhoneNumber(): void
+it('testItUpdatesPhoneNumber', function () {
-    {
     $this->withoutExceptionHandling()->login()->loginNami();
 
-        $this->post('/member', $this->attributes([
+    $this->post('/member', MemberStoreRequestFactory::new()->create([
         'has_nami' => false,
         'main_phone' => '02103 4455129',
         'fax' => '02103 4455130',
@@ -155,13 +148,12 @@ class StoreTest extends TestCase
         'fax' => '+49 2103 4455130',
         'children_phone' => '+49 2103 4455130',
     ]);
-    }
+});
 
-    public function testItHasErrorWhenPhoneNumberIsInvalid(): void
+it('testItHasErrorWhenPhoneNumberIsInvalid', function () {
-    {
     $this->login()->loginNami();
 
-        $response = $this->post('/member', $this->attributes([
+    $response = $this->post('/member', MemberStoreRequestFactory::new()->create([
         'has_nami' => false,
         'main_phone' => '1111111111111111',
         'mobile_phone' => '1111111111111111',
@@ -175,14 +167,13 @@ class StoreTest extends TestCase
         'children_phone' => 'Telefon (Kind) ist keine valide Nummer.',
         'fax' => 'Fax ist keine valide Nummer.',
     ]);
-    }
+});
 
-    public function testItDoesntRequireBirthdayWhenNotInNami(): void
+it('testItDoesntRequireBirthdayWhenNotInNami', function () {
-    {
     $this->login()->loginNami();
 
     $this
-            ->post('/member', $this->attributes([
+        ->post('/member', MemberStoreRequestFactory::new()->create([
             'nationality_id' => null,
             'birthday' => null,
             'has_nami' => false,
@@ -199,28 +190,26 @@ class StoreTest extends TestCase
         'location' => null,
         'joined_at' => null,
     ]);
-    }
+});
 
-    public function testItDoesntNeedSubscription(): void
+it('testItDoesntNeedSubscription', function () {
-    {
     $this->login()->loginNami();
 
     $this
-            ->post('/member', $this->attributes([
+        ->post('/member', MemberStoreRequestFactory::new()->create([
             'has_nami' => false,
             'subscription_id' => null,
         ]))->assertSessionDoesntHaveErrors();
     $this->assertDatabaseHas('members', [
         'subscription_id' => null,
     ]);
-    }
+});
 
-    public function testItRequiresFields(): void
+it('testItRequiresFields', function () {
-    {
     $this->login()->loginNami();
 
     $this
-            ->post('/member', $this->attributes([
+        ->post('/member', MemberStoreRequestFactory::new()->create([
             'nationality_id' => null,
             'birthday' => '',
             'address' => '',
@@ -229,65 +218,19 @@ class StoreTest extends TestCase
             'joined_at' => '',
         ]))
         ->assertSessionHasErrors(['nationality_id', 'birthday', 'address', 'zip', 'location', 'joined_at']);
-    }
+});
 
-    public function testSubscriptionIsRequiredIfFirstActivityIsPaid(): void
+it('testSubscriptionIsRequiredIfFirstActivityIsPaid', function () {
-    {
     $this->login()->loginNami();
     $activity = Activity::factory()->name('€ Mitglied')->create();
     $subactivity = Subactivity::factory()->create();
 
     $this
         ->from('/member/create')
-            ->post('/member', $this->attributes([
+        ->post('/member', MemberStoreRequestFactory::new()->create([
             'first_activity_id' => $activity->id,
             'first_subactivity_id' => $subactivity->id,
             'subscription_id' => null,
         ]))
         ->assertSessionHasErrors(['subscription_id' => 'Beitragsart ist erforderlich.']);
-    }
+});
-
-    /**
-     * @return array<string, mixed>
-     */
-    public function defaults(): array
-    {
-        $country = Country::factory()->create();
-        $nationality = Nationality::factory()->create();
-        $subscription = Subscription::factory()->forFee()->create();
-
-        return [
-            'address' => 'Bavert 50',
-            'birthday' => '2013-02-19',
-            'children_phone' => '+49 176 70512778',
-            'efz' => '',
-            'email' => '',
-            'email_parents' => 'osloot@aol.com',
-            'fax' => '+49 212 4732223',
-            'firstname' => 'Joe',
-            'further_address' => '',
-            'has_nami' => true,
-            'has_svk' => false,
-            'has_vk' => false,
-            'joined_at' => '2022-08-12',
-            'lastname' => 'Muster',
-            'letter_address' => '',
-            'location' => 'Solingen',
-            'main_phone' => '+49 212 337056',
-            'mobile_phone' => '+49 176 70512774',
-            'more_ps_at' => '',
-            'multiply_more_pv' => false,
-            'multiply_pv' => false,
-            'other_country' => '',
-            'ps_at' => '',
-            'send_newspaper' => true,
-            'without_education_at' => '',
-            'without_efz_at' => '',
-            'work_phone' => '',
-            'zip' => '42719',
-            'country_id' => $country->id,
-            'nationality_id' => $nationality->id,
-            'subscription_id' => $subscription->id,
-        ];
-    }
-}

tests/RequestFactories/MemberStoreRequestFactory.php

@@ -0,0 +1,52 @@
+<?php
+
+namespace Tests\RequestFactories;
+
+use App\Country;
+use App\Nationality;
+use App\Payment\Subscription;
+use Worksome\RequestFactories\RequestFactory;
+
+class MemberStoreRequestFactory extends RequestFactory
+{
+    public function definition(): array
+    {
+        $country = Country::factory()->create();
+        $nationality = Nationality::factory()->create();
+        $subscription = Subscription::factory()->forFee()->create();
+
+        return [
+            'address' => 'Bavert 50',
+            'birthday' => '2013-02-19',
+            'children_phone' => '+49 176 70512778',
+            'efz' => '',
+            'email' => '',
+            'email_parents' => 'osloot@aol.com',
+            'fax' => '+49 212 4732223',
+            'firstname' => 'Joe',
+            'further_address' => '',
+            'has_nami' => true,
+            'has_svk' => false,
+            'has_vk' => false,
+            'joined_at' => '2022-08-12',
+            'lastname' => 'Muster',
+            'letter_address' => '',
+            'location' => 'Solingen',
+            'main_phone' => '+49 212 337056',
+            'mobile_phone' => '+49 176 70512774',
+            'more_ps_at' => '',
+            'multiply_more_pv' => false,
+            'multiply_pv' => false,
+            'other_country' => '',
+            'ps_at' => '',
+            'send_newspaper' => true,
+            'without_education_at' => '',
+            'without_efz_at' => '',
+            'work_phone' => '',
+            'zip' => '42719',
+            'country_id' => $country->id,
+            'nationality_id' => $nationality->id,
+            'subscription_id' => $subscription->id,
+        ];
+    }
+}