This commit is contained in:
philipp lang 2022-02-12 01:16:37 +01:00
parent 8c6704faa4
commit 843a7137cc
6 changed files with 31 additions and 16 deletions

View File

@ -5,19 +5,22 @@ namespace App\Payment;
use App\Http\Controllers\Controller;
use App\Member\Member;
use App\Payment\Status;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Inertia\Response;
class AllpaymentController extends Controller
{
public function create() {
public function create(): Response
{
session()->put('menu', 'member');
session()->put('title', 'Rechnungen erstellen');
return \Inertia::render('allpayment/Form', [
]);
return \Inertia::render('allpayment/Form');
}
public function store(Request $request) {
public function store(Request $request): RedirectResponse
{
$request->validate([
'year' => 'required|numeric'
]);

View File

@ -4,11 +4,14 @@ namespace App\Payment;
use App\Fee;
use App\Http\Controllers\Controller;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Inertia\Response;
class SubscriptionController extends Controller
{
public function index(Request $request) {
public function index(Request $request): Response
{
session()->put('menu', 'subscription');
session()->put('title', 'Beiträge');
@ -18,7 +21,8 @@ class SubscriptionController extends Controller
]);
}
public function create() {
public function create(): Response
{
session()->put('menu', 'subscription');
session()->put('title', 'Beitrag erstellen');
@ -29,7 +33,8 @@ class SubscriptionController extends Controller
]);
}
public function store(Request $request) {
public function store(Request $request): RedirectResponse
{
Subscription::create($request->validate([
'name' => 'required|max:255',
'amount' => 'required|numeric',
@ -39,7 +44,8 @@ class SubscriptionController extends Controller
return redirect()->route('subscription.index');
}
public function edit(Subscription $subscription, Request $request) {
public function edit(Subscription $subscription, Request $request): Response
{
session()->put('menu', 'subscription');
session()->put('title', "Beitrag {$subscription->name} bearbeiten");
@ -50,7 +56,8 @@ class SubscriptionController extends Controller
]);
}
public function update(Subscription $subscription, Request $request) {
public function update(Subscription $subscription, Request $request): RedirectResponse
{
$subscription->update($request->validate([
'name' => 'required|max:255',
'amount' => 'required|numeric',

View File

@ -4,12 +4,13 @@ namespace App\Pdf;
use App\Http\Controllers\Controller;
use App\Member\Member;
use Illuminate\Contracts\Support\Responsable;
use Illuminate\Http\Request;
class MemberPdfController extends Controller
{
public function __invoke(Request $request, Member $member)
public function __invoke(Request $request, Member $member): Responsable
{
$repo = app(PdfRepositoryFactory::class)->fromSingleRequest($request->type, $member);

View File

@ -9,7 +9,7 @@ parameters:
- database
# The level 8 is the highest level
level: 5
level: 6
ignoreErrors:
- '#Call to an undefined method Illuminate\\Contracts\\Auth\\Authenticatable::api\(\)#'

View File

@ -162,7 +162,8 @@ class InitializeTest extends TestCase
]);
}
public function membershipDataProvider() {
public function membershipDataProvider(): array
{
return [
'dont_fetch_activity_from_group' => [
[

View File

@ -7,7 +7,7 @@ use PHPUnit\Framework\Assert as PHPUnit;
trait TestsInertia {
public function assertInertiaHas($value, TestResponse $response, ?string $key = null): void
public function assertInertiaHas(mixed $value, TestResponse $response, ?string $key = null): void
{
$bindings = json_decode(json_encode($value), true);
$viewData = json_decode(json_encode(
@ -18,11 +18,13 @@ trait TestsInertia {
$this->assertInertiaDeepNest($bindings, $viewData);
}
public function assertComponent(string $component, TestResponse $response) {
public function assertComponent(string $component, TestResponse $response): void
{
PHPUnit::assertEquals($component, $response->viewData('page')['component']);
}
public function assertInertiaDeepNest($should, $is) {
public function assertInertiaDeepNest(mixed $should, mixed $is): void
{
foreach ($should as $key => $value) {
PHPUnit::assertArrayHasKey($key, $is);
@ -35,7 +37,8 @@ trait TestsInertia {
}
}
public function inertia(TestResponse $response, string $key) {
public function inertia(TestResponse $response, string $key): mixed
{
return data_get($response->viewData('page')['props'], $key);
}