From 8e382126fd8f28df1e7c4dfd5a4ef4a84fc3ebd4 Mon Sep 17 00:00:00 2001
From: philipp lang <philipp@aweos.de>
Date: Sat, 25 Feb 2023 19:12:07 +0100
Subject: [PATCH] Add: delete activity

---
 app/Activity/Actions/DestroyAction.php | 24 +++++++++++--
 resources/js/views/activity/VIndex.vue | 37 +++++++++++++++++--
 tests/Feature/Activity/DestroyTest.php | 49 ++++++++++++++++++++++++++
 3 files changed, 106 insertions(+), 4 deletions(-)
 create mode 100644 tests/Feature/Activity/DestroyTest.php

diff --git a/app/Activity/Actions/DestroyAction.php b/app/Activity/Actions/DestroyAction.php
index f5c7f7de..e02306fe 100644
--- a/app/Activity/Actions/DestroyAction.php
+++ b/app/Activity/Actions/DestroyAction.php
@@ -2,14 +2,34 @@
 
 namespace App\Activity\Actions;
 
+use App\Activity;
+use App\Member\Membership;
+use Illuminate\Http\RedirectResponse;
+use Illuminate\Validation\ValidationException;
 use Lorisleiva\Actions\Concerns\AsAction;
 
 class DestroyAction
 {
     use AsAction;
 
-    public function handle()
+    public function handle(Activity $activity): void
     {
-        // ...
+        $activity->subactivities()->sync([]);
+        $activity->delete();
+    }
+
+    public function asController(Activity $activity): RedirectResponse
+    {
+        if (Membership::where('activity_id', $activity->id)->count()) {
+            throw ValidationException::withMessages(['activity' => 'Tätigkeit besitzt noch Mitglieder.']);
+        }
+
+        if ($activity->hasNami) {
+            throw ValidationException::withMessages(['activity' => 'Tätigkeit ist in NaMi.']);
+        }
+
+        $this->handle($activity);
+
+        return redirect()->route('activity.index');
     }
 }
diff --git a/resources/js/views/activity/VIndex.vue b/resources/js/views/activity/VIndex.vue
index aa2678a2..f36b51a0 100644
--- a/resources/js/views/activity/VIndex.vue
+++ b/resources/js/views/activity/VIndex.vue
@@ -1,5 +1,16 @@
 <template>
     <div class="pb-6">
+        <popup heading="Bitte bestätigen" v-if="deleting !== null">
+            <div>
+                <p class="mt-4">
+                    Diese Aktivität löschen?
+                </p>
+                <div class="grid grid-cols-2 gap-3 mt-6">
+                    <a href="#" @click.prevent="remove" class="text-center btn btn-danger">Löschen</a>
+                    <a href="#" @click.prevent="deleting = null" class="text-center btn btn-primary">Abbrechen</a>
+                </div>
+            </div>
+        </popup>
         <table cellspacing="0" cellpadding="0" border="0" class="custom-table custom-table-sm table">
             <thead>
                 <th>Name</th>
@@ -13,7 +24,7 @@
                         <i-link :href="activity.links.edit" class="inline-flex btn btn-warning btn-sm" v-tooltip="`bearbeiten`"><svg-sprite src="pencil"></svg-sprite></i-link>
                         <i-link
                             href="#"
-                            @click.prevent="$emit('remove')"
+                            @click.prevent="deleting = activity"
                             class="inline-flex btn btn-danger btn-sm"
                             v-tooltip="`Entfernen`"
                             ><svg-sprite src="trash"></svg-sprite
@@ -35,8 +46,30 @@ import indexHelpers from '../../mixins/indexHelpers';
 
 export default {
 
-    mixins: [indexHelpers],
+    data: function() {
+        return {
+            deleting: null,
+        };
+    },
 
+    methods: {
+        remove() {
+            var _self = this;
+            this.$inertia.delete(this.deleting.links.destroy, {
+                preserveState: true,
+                onSuccess(page) {
+                    _self.inner = page.props.data;
+                    _self.deleting = null;
+                }
+            });
+        }
+    },
+
+    components: {
+        popup: () => import('../../components/Popup.vue'),
+    },
+
+    mixins: [indexHelpers],
 
 };
 </script>
diff --git a/tests/Feature/Activity/DestroyTest.php b/tests/Feature/Activity/DestroyTest.php
new file mode 100644
index 00000000..48bbf7fe
--- /dev/null
+++ b/tests/Feature/Activity/DestroyTest.php
@@ -0,0 +1,49 @@
+<?php
+
+namespace Tests\Feature\Activity;
+
+use App\Activity;
+use App\Member\Member;
+use App\Member\Membership;
+use App\Subactivity;
+use Illuminate\Foundation\Testing\DatabaseTransactions;
+use Tests\TestCase;
+
+class DestroyTest extends TestCase
+{
+    use DatabaseTransactions;
+
+    public function testItDeletesAnActivity(): void
+    {
+        $this->login()->loginNami();
+        $activity = Activity::factory()->hasAttached(Subactivity::factory())->create();
+
+        $response = $this->delete(route('activity.destroy', ['activity' => $activity]));
+
+        $response->assertRedirect('/activity');
+        $this->assertDatabaseCount('activities', 0);
+    }
+
+    public function testItCannotDeleteAnActivityThatHasMemberships(): void
+    {
+        $this->login()->loginNami();
+        $activity = Activity::factory()->create();
+        Member::factory()->defaults()->has(Membership::factory()->for($activity))->create();
+
+        $response = $this->delete(route('activity.destroy', ['activity' => $activity]));
+
+        $response->assertSessionHasErrors(['activity' => 'Tätigkeit besitzt noch Mitglieder.']);
+    }
+
+    public function testItCannotDeleteActivityInNami(): void
+    {
+        $this->login()->loginNami();
+        $activity = Activity::factory()->inNami(66)->create();
+
+        $response = $this->delete(route('activity.destroy', ['activity' => $activity]));
+
+        $response->assertSessionHasErrors(['activity' => 'Tätigkeit ist in NaMi.']);
+    }
+
+
+}