silva
/
adrema
2
1
Fork 0
Code Issues 23 Pull Requests 1 Projects 1 Releases 106 Wiki Activity

fix deleting actions

This commit is contained in:
Philipp Lang 2023-10-18 13:45:41 +02:00
parent a84d9f428d
commit 9a898315a0
2 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/Membership/Actions/MembershipDestroyAction.php
View File

@ -16,8 +16,9 @@ class MembershipDestroyAction
use AsAction; use AsAction;
use TracksJob; use TracksJob;
public function handle(Membership $membership): void public function handle(int $membershipId): void
{ {
$membership = Membership::find($membershipId);
$api = app(NamiSettings::class)->login(); $api = app(NamiSettings::class)->login();
if ($membership->hasNami) { if ($membership->hasNami) {
@ -38,7 +39,7 @@ class MembershipDestroyAction
public function asController(Membership $membership): JsonResponse public function asController(Membership $membership): JsonResponse
{ {
$this->startJob($membership); $this->startJob($membership->id, $membership->member->fullname);
return response()->json([]); return response()->json([]);
} }
@ -48,12 +49,12 @@ class MembershipDestroyAction
*/ */
public function jobState(WithJobState $jobState, ...$parameters): WithJobState public function jobState(WithJobState $jobState, ...$parameters): WithJobState
{ {
$member = $parameters[0]->member; $memberName = $parameters[1];
return $jobState return $jobState
->before('Mitgliedschaft für ' . $member->fullname . ' wird gelöscht') ->before('Mitgliedschaft für ' . $memberName . ' wird gelöscht')
->after('Mitgliedschaft für ' . $member->fullname . ' gelöscht') ->after('Mitgliedschaft für ' . $memberName . ' gelöscht')
->failed('Fehler beim Löschen der Mitgliedschaft für ' . $member->fullname) ->failed('Fehler beim Löschen der Mitgliedschaft für ' . $memberName)
->shouldReload(JobChannels::make()->add('member')->add('membership')); ->shouldReload(JobChannels::make()->add('member')->add('membership'));
} }
} }

14
app/Payment/Actions/PaymentDestroyAction.php
View File

@ -14,14 +14,14 @@ class PaymentDestroyAction
use AsAction; use AsAction;
use TracksJob; use TracksJob;
public function handle(Payment $payment): void public function handle(int $paymentId): void
{ {
$payment->delete(); Payment::find($paymentId)->delete();
} }
public function asController(Payment $payment): JsonResponse public function asController(Payment $payment): JsonResponse
{ {
$this->startJob($payment); $this->startJob($payment->id, $payment->member->fullname);
return response()->json([]); return response()->json([]);
} }
@ -31,12 +31,12 @@ class PaymentDestroyAction
*/ */
public function jobState(WithJobState $jobState, ...$parameters): WithJobState public function jobState(WithJobState $jobState, ...$parameters): WithJobState
{ {
$member = $parameters[0]->member; $memberName = $parameters[1];
return $jobState return $jobState
->before('Zahlung für ' . $member->fullname . ' wird gelöscht') ->before('Zahlung für ' . $memberName . ' wird gelöscht')
->after('Zahlung für ' . $member->fullname . ' gelöscht') ->after('Zahlung für ' . $memberName . ' gelöscht')
->failed('Fehler beim Löschen der Zahlung für ' . $member->fullname) ->failed('Fehler beim Löschen der Zahlung für ' . $memberName)
->shouldReload(JobChannels::make()->add('member')->add('payment')); ->shouldReload(JobChannels::make()->add('member')->add('payment'));
} }
} }