silva
/
adrema
2
1
Fork 0
Code Issues 23 Pull Requests 1 Projects 1 Releases 106 Wiki Activity

fix: pull members with no fee
continuous-integration/drone/push Build is passing Details

This commit is contained in:
Philipp Lang 2023-03-06 15:18:48 +01:00
parent 0ee051879b
commit a3d9b69e79
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/Actions/InsertMemberAction.php
View File

@ -55,7 +55,11 @@ class InsertMemberAction
public function getSubscription(NamiMember $member): ?Subscription public function getSubscription(NamiMember $member): ?Subscription
{ {
$fee = Fee::nami($member->feeId ?: -1); if (is_null($member->feeId)) {
return null;
}
$fee = Fee::nami($member->feeId);
if (is_null($fee)) { if (is_null($fee)) {
$feeName = $member->feeName ?: 'Default'; $feeName = $member->feeName ?: 'Default';

15
tests/Feature/Member/PullMemberActionTest.php
View File

@ -138,4 +138,19 @@ class PullMemberActionTest extends TestCase
'subscription_id' => $subscription->id, 'subscription_id' => $subscription->id,
]); ]);
} }
public function testItPullsMemberWithNoSubscription(): void
{
Region::factory()->inNami(999)->name('nicht-de')->create(['is_null' => true]);
app(MemberFake::class)->shows(1000, 1001, [
'beitragsartId' => null,
'beitragsart' => null,
]);
app(PullMemberAction::class)->handle(1000, 1001);
$this->assertDatabaseHas('members', [
'subscription_id' => null,
]);
}
} }