silva
/
adrema
2
1
Fork 0
Code Issues 23 Pull Requests 1 Projects 1 Releases 104 Wiki Activity

Fix: Dont Send mail to participants without mail

This commit is contained in:
philipp lang 2024-07-04 22:09:24 +02:00
parent d26bdd72fb
commit f7d9328447
2 changed files with 26 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/Form/Actions/PreventionRememberAction.php
View File

@ -26,6 +26,10 @@ class PreventionRememberAction
return; return;
} }
if ($participant->getFields()->getMailRecipient() === null) {
continue;
}
Mail::send(new PreventionRememberMail($participant)); Mail::send(new PreventionRememberMail($participant));
$participant->update(['last_remembered_at' => now()]); $participant->update(['last_remembered_at' => now()]);

24
tests/Feature/Member/PreventionTest.php
View File

@ -5,12 +5,14 @@ namespace Tests\Feature\Member;
use App\Prevention\Enums\Prevention; use App\Prevention\Enums\Prevention;
use App\Form\Actions\PreventionRememberAction; use App\Form\Actions\PreventionRememberAction;
use App\Form\Enums\NamiType; use App\Form\Enums\NamiType;
use App\Form\Enums\SpecialType;
use App\Form\Models\Form; use App\Form\Models\Form;
use App\Form\Models\Participant; use App\Form\Models\Participant;
use App\Invoice\InvoiceSettings; use App\Invoice\InvoiceSettings;
use App\Prevention\Mails\PreventionRememberMail; use App\Prevention\Mails\PreventionRememberMail;
use App\Member\Member; use App\Member\Member;
use App\Member\Membership; use App\Member\Membership;
use App\Prevention\PreventionSettings;
use Generator; use Generator;
use Illuminate\Foundation\Testing\DatabaseTransactions; use Illuminate\Foundation\Testing\DatabaseTransactions;
use Illuminate\Support\Facades\Mail; use Illuminate\Support\Facades\Mail;
@ -157,6 +159,18 @@ class PreventionTest extends TestCase
} }
} }
public function testItDoesntRememberParticipantThatHasNoMail(): void
{
Mail::fake();
$form = $this->createForm();
$participant = $this->createParticipant($form);
$participant->update(['data' => [...$participant->data, 'email' => '']]);
PreventionRememberAction::run();
Mail::assertNotSent(PreventionRememberMail::class);
}
public function testItRendersMail(): void public function testItRendersMail(): void
{ {
InvoiceSettings::fake(['from_long' => 'Stamm Beispiel']); InvoiceSettings::fake(['from_long' => 'Stamm Beispiel']);
@ -173,12 +187,18 @@ class PreventionTest extends TestCase
protected function createForm(): Form protected function createForm(): Form
{ {
return Form::factory()->fields([ return Form::factory()->fields([
$this->textField('vorname')->namiType(NamiType::FIRSTNAME), $this->textField('vorname')->namiType(NamiType::FIRSTNAME)->specialType(SpecialType::FIRSTNAME),
$this->textField('nachname')->namiType(NamiType::FIRSTNAME)->specialType(SpecialType::LASTNAME),
$this->textField('email')->namiType(NamiType::FIRSTNAME)->specialType(SpecialType::EMAIL),
])->create(['needs_prevention' => true]); ])->create(['needs_prevention' => true]);
} }
protected function createParticipant(Form $form): Participant protected function createParticipant(Form $form): Participant
{ {
return Participant::factory()->for($form)->data(['vorname' => 'Max'])->for(Member::factory()->defaults()->has(Membership::factory()->inLocal('€ LeiterIn', 'Wölfling')))->create(); return Participant::factory()->for($form)->data([
'vorname' => 'Max',
'nachname' => 'Muster',
'enail' => 'mail@a.de',
])->for(Member::factory()->defaults()->has(Membership::factory()->inLocal('€ LeiterIn', 'Wölfling')))->create();
} }
} }