Compare commits

...

7 Commits

Author SHA1 Message Date
philipp lang 4d46de2763 Lint
continuous-integration/drone/push Build is failing Details
2025-05-28 21:58:54 +02:00
philipp lang edf836235b Add yearly mail 2025-05-28 21:57:31 +02:00
philipp lang 67e50709c0 Mod mailRecipient in template 2025-05-28 19:00:04 +02:00
philipp lang 4ba13a6c42 Make mailRecipient optional 2025-05-28 18:46:12 +02:00
philipp lang a8bdc2c4b2 Lint 2025-05-28 18:40:53 +02:00
philipp lang aa7cdb3fa3 Mod signature for Prevention remember forms command 2025-05-27 20:07:35 +02:00
philipp lang c6c01a3e24 Add setting for yearly prevention mail 2025-05-27 19:33:35 +02:00
15 changed files with 324 additions and 81 deletions

View File

@ -13,18 +13,18 @@ class PreventionRememberAction
{
use AsAction;
public string $commandSignature = 'prevention:remember';
public string $commandSignature = 'prevention:remember-forms';
public function handle(): void
{
$query = Participant::whereHas(
'form',
fn ($form) => $form
fn($form) => $form
->where('needs_prevention', true)
->where('from', '>=', now())
)
->where(
fn ($q) => $q
fn($q) => $q
->where('last_remembered_at', '<=', now()->subWeeks(2))
->orWhereNull('last_remembered_at')
);
@ -33,7 +33,7 @@ class PreventionRememberAction
continue;
}
if ($participant->getFields()->getMailRecipient() === null || count($participant->preventions()) === 0) {
if ($participant->getFields()->getMailRecipient() === null || $participant->preventions()->count() === 0) {
continue;
}

View File

@ -14,6 +14,7 @@ use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\BelongsTo;
use Illuminate\Database\Eloquent\Relations\HasMany;
use Illuminate\Support\Collection;
use Illuminate\Support\Facades\Mail;
use Laravel\Scout\Searchable;
use stdClass;
@ -81,20 +82,15 @@ class Participant extends Model implements Preventable
Mail::to($this->getMailRecipient())->queue(new ConfirmRegistrationMail($this));
}
public function preventableLayout(): string
{
return 'mail.prevention.prevention-remember-participant';
}
/**
* @inheritdoc
*/
public function preventions(): array
public function preventions(): Collection
{
return $this->member?->preventions($this->form->from) ?: [];
return $this->member?->preventions($this->form->from) ?: collect([]);
}
public function getMailRecipient(): stdClass
public function getMailRecipient(): ?stdClass
{
return $this->getFields()->getMailRecipient();
}

View File

@ -13,6 +13,8 @@ use App\Nami\HasNamiField;
use App\Nationality;
use App\Payment\Subscription;
use App\Pdf\Sender;
use App\Prevention\Contracts\Preventable;
use App\Prevention\Data\PreventionData;
use App\Region;
use App\Setting\NamiSettings;
use Carbon\Carbon;
@ -35,12 +37,14 @@ use Zoomyboy\Phone\HasPhoneNumbers;
use App\Prevention\Enums\Prevention;
use Database\Factories\Member\MemberFactory;
use Illuminate\Database\Eloquent\Relations\HasOne;
use Illuminate\Support\Collection;
use stdClass;
/**
* @property string $subscription_name
* @property int $pending_payment
*/
class Member extends Model implements Geolocatable
class Member extends Model implements Geolocatable, Preventable
{
use Notifiable;
use HasNamiField;
@ -191,7 +195,21 @@ class Member extends Model implements Geolocatable
protected function getAusstand(): int
{
return (int) $this->invoicePositions()->whereHas('invoice', fn ($query) => $query->whereNeedsPayment())->sum('price');
return (int) $this->invoicePositions()->whereHas('invoice', fn($query) => $query->whereNeedsPayment())->sum('price');
}
public function getMailRecipient(): ?stdClass
{
if (!$this->fullname) {
return null;
}
return (object) ['name' => $this->fullname, 'email' => $this->email];
}
public function preventableSubject(): string
{
return 'Nachweise erforderlich';
}
// ---------------------------------- Relations ----------------------------------
@ -339,7 +357,7 @@ class Member extends Model implements Geolocatable
return $query->addSelect([
'pending_payment' => InvoicePosition::selectRaw('SUM(price)')
->whereColumn('invoice_positions.member_id', 'members.id')
->whereHas('invoice', fn ($query) => $query->whereNeedsPayment()),
->whereHas('invoice', fn($query) => $query->whereNeedsPayment()),
]);
}
@ -350,7 +368,7 @@ class Member extends Model implements Geolocatable
*/
public function scopeWhereHasPendingPayment(Builder $query): Builder
{
return $query->whereHas('invoicePositions', fn ($q) => $q->whereHas('invoice', fn ($q) => $q->whereNeedsPayment()));
return $query->whereHas('invoicePositions', fn($q) => $q->whereHas('invoice', fn($q) => $q->whereNeedsPayment()));
}
/**
@ -364,32 +382,47 @@ class Member extends Model implements Geolocatable
}
/**
* @return array<int, Prevention>
* @inheritdoc
*/
public function preventions(?Carbon $date = null): array
public function preventions(?Carbon $date = null): Collection
{
$date = $date ?: now();
/** @var array<int, Prevention> */
$preventions = [];
/** @var Collection<int, PreventionData> */
$preventions = collect([]);
if ($this->efz === null || $this->efz->diffInYears($date) >= 5) {
$preventions[] = Prevention::EFZ;
$preventions->push(PreventionData::from([
'type' => Prevention::EFZ,
'expires' => $this->efz === null ? now() : $this->efz->addYears(5)
]));
}
if (!$this->has_vk) {
$preventions[] = Prevention::VK;
$preventions->push(PreventionData::from([
'type' => Prevention::VK,
'expires' => now(),
]));
}
if ($this->more_ps_at === null) {
if ($this->ps_at === null) {
$preventions[] = Prevention::PS;
$preventions->push(PreventionData::from([
'type' => Prevention::PS,
'expires' => now(),
]));
} else if ($this->ps_at->diffInYears($date) >= 5) {
$preventions[] = Prevention::MOREPS;
$preventions->push(PreventionData::from([
'type' => Prevention::MOREPS,
'expires' => $this->ps_at->addYears(5),
]));
}
} else {
if ($this->more_ps_at === null || $this->more_ps_at->diffInYears($date) >= 5) {
$preventions[] = Prevention::MOREPS;
$preventions->push(PreventionData::from([
'type' => Prevention::MOREPS,
'expires' => $this->more_ps_at->addYears(5),
]));
}
}
@ -499,7 +532,7 @@ class Member extends Model implements Geolocatable
'name' => $this->fullname,
'address' => $this->address,
'zipLocation' => $this->zip . ' ' . $this->location,
'mglnr' => Lazy::create(fn () => 'Mglnr.: ' . $this->nami_id),
'mglnr' => Lazy::create(fn() => 'Mglnr.: ' . $this->nami_id),
]);
}
@ -508,7 +541,7 @@ class Member extends Model implements Geolocatable
*/
public static function forSelect(): array
{
return static::select(['id', 'firstname', 'lastname'])->get()->map(fn ($member) => ['id' => $member->id, 'name' => $member->fullname])->toArray();
return static::select(['id', 'firstname', 'lastname'])->get()->map(fn($member) => ['id' => $member->id, 'name' => $member->fullname])->toArray();
}
// -------------------------------- Geolocation --------------------------------
@ -567,7 +600,7 @@ class Member extends Model implements Geolocatable
'age_group_icon' => $this->ageGroupMemberships->first()?->subactivity->slug,
'is_leader' => $this->leaderMemberships()->count() > 0,
'memberships' => $this->memberships()->active()->get()
->map(fn ($membership) => [...$membership->only('activity_id', 'subactivity_id'), 'both' => $membership->activity_id . '|' . $membership->subactivity_id, 'with_group' => $membership->group_id . '|' . $membership->activity_id . '|' . $membership->subactivity_id]),
->map(fn($membership) => [...$membership->only('activity_id', 'subactivity_id'), 'both' => $membership->activity_id . '|' . $membership->subactivity_id, 'with_group' => $membership->group_id . '|' . $membership->activity_id . '|' . $membership->subactivity_id]),
];
}
}

View File

@ -19,6 +19,7 @@ class SettingStoreAction
{
return [
'formmail' => 'array',
'yearlymail' => 'array',
];
}
@ -26,6 +27,7 @@ class SettingStoreAction
{
$settings = app(PreventionSettings::class);
$settings->formmail = EditorData::from($request->formmail);
$settings->yearlymail = EditorData::from($request->yearlymail);
$settings->save();
Succeeded::message('Einstellungen gespeichert.')->dispatch();

View File

@ -0,0 +1,55 @@
<?php
namespace App\Prevention\Actions;
use App\Member\Member;
use App\Prevention\Data\PreventionData;
use App\Prevention\Mails\YearlyMail;
use App\Prevention\PreventionSettings;
use Illuminate\Support\Collection;
use Illuminate\Support\Facades\Mail;
use Lorisleiva\Actions\Concerns\AsAction;
class YearlyRememberAction
{
use AsAction;
public string $commandSignature = 'prevention:remember-yearly';
public function handle(): void
{
$settings = app(PreventionSettings::class);
$expireDate = now()->addWeeks($settings->weeks);
foreach (Member::get() as $member) {
$noticePreventions = $member->preventions($expireDate)
->filter(fn($prevention) => $prevention->expiresAt($expireDate));
if ($noticePreventions->count() === 0) {
continue;
}
Mail::send($this->createMail($member, $noticePreventions));
}
foreach (Member::get() as $member) {
$preventions = $member->preventions()
->filter(fn($prevention) => $prevention->expiresAt(now()));
if ($preventions->count() === 0) {
continue;
}
Mail::send($this->createMail($member, $preventions));
}
}
/**
* @param Collection<int, PreventionData> $preventions
*/
protected function createMail(Member $member, Collection $preventions): YearlyMail
{
$body = app(PreventionSettings::class)->refresh()->formmail;
return new YearlyMail($member, $body, $preventions);
}
}

View File

@ -2,19 +2,19 @@
namespace App\Prevention\Contracts;
use App\Prevention\Enums\Prevention;
use App\Prevention\Data\PreventionData;
use Illuminate\Support\Collection;
use stdClass;
interface Preventable
{
public function preventableLayout(): string;
public function preventableSubject(): string;
/**
* @return array<int, Prevention>
* @return Collection<int, PreventionData>
*/
public function preventions(): array;
public function preventions(): Collection;
public function getMailRecipient(): stdClass;
public function getMailRecipient(): ?stdClass;
}

View File

@ -0,0 +1,17 @@
<?php
namespace App\Prevention\Data;
use App\Prevention\Enums\Prevention;
use Carbon\Carbon;
use Spatie\LaravelData\Data;
class PreventionData extends Data
{
public function __construct(public Prevention $type, public Carbon $expires) {}
public function expiresAt(Carbon $date): bool
{
return $this->expires->isSameDay($date);
}
}

View File

@ -2,8 +2,6 @@
namespace App\Prevention\Enums;
use App\Member\Member;
use Carbon\Carbon;
use Illuminate\Support\Collection;
enum Prevention
@ -44,7 +42,7 @@ enum Prevention
*/
public static function items(array $preventions): Collection
{
return collect(static::cases())->map(fn ($case) => [
return collect(static::cases())->map(fn($case) => [
'letter' => $case->letter(),
'value' => !in_array($case, $preventions),
'tooltip' => $case->tooltip(!in_array($case, $preventions)),

View File

@ -25,7 +25,7 @@ class PreventionRememberMail extends Mailable
{
$this->settings = app(InvoiceSettings::class);
$this->bodyText = $this->bodyText
->replaceWithList('wanted', collect($preventable->preventions())->map(fn ($prevention) => $prevention->text())->toArray());
->replaceWithList('wanted', collect($preventable->preventions())->map(fn($prevention) => $prevention->type->text())->toArray());
}
/**
@ -48,7 +48,7 @@ class PreventionRememberMail extends Mailable
public function content()
{
return new Content(
markdown: $this->preventable->preventableLayout(),
markdown: 'mail.prevention.prevention-remember-participant',
);
}

View File

@ -0,0 +1,68 @@
<?php
namespace App\Prevention\Mails;
use App\Invoice\InvoiceSettings;
use App\Lib\Editor\EditorData;
use App\Prevention\Contracts\Preventable;
use App\Prevention\Data\PreventionData;
use Illuminate\Bus\Queueable;
use Illuminate\Mail\Attachment;
use Illuminate\Mail\Mailable;
use Illuminate\Mail\Mailables\Content;
use Illuminate\Mail\Mailables\Envelope;
use Illuminate\Queue\SerializesModels;
use Illuminate\Support\Collection;
class YearlyMail extends Mailable
{
use Queueable, SerializesModels;
public InvoiceSettings $settings;
/**
* Create a new message instance.
*
* @param Collection<int, PreventionData> $preventions
*/
public function __construct(public Preventable $preventable, public EditorData $bodyText, public Collection $preventions)
{
$this->settings = app(InvoiceSettings::class);
$this->bodyText = $this->bodyText
->replaceWithList('wanted', collect($preventions)->pluck('type')->map(fn($prevention) => $prevention->text())->toArray());
}
/**
* Get the message envelope.
*
* @return \Illuminate\Mail\Mailables\Envelope
*/
public function envelope()
{
return (new Envelope(
subject: $this->preventable->preventableSubject(),
))->to($this->preventable->getMailRecipient()->email, $this->preventable->getMailRecipient()->name);
}
/**
* Get the message content definition.
*
* @return \Illuminate\Mail\Mailables\Content
*/
public function content()
{
return new Content(
markdown: 'mail.prevention.prevention-remember-participant',
);
}
/**
* Get the attachments for the message.
*
* @return array<int, Attachment>
*/
public function attachments(): array
{
return [];
}
}

View File

@ -9,6 +9,8 @@ class PreventionSettings extends LocalSettings
{
public EditorData $formmail;
public EditorData $yearlymail;
public int $weeks;
public static function group(): string
{

View File

@ -0,0 +1,12 @@
<?php
use Spatie\LaravelSettings\Migrations\SettingsMigration;
return new class extends SettingsMigration
{
public function up(): void
{
$this->migrator->add('prevention.yearlymail', ['time' => 1, 'blocks' => [], 'version' => '1.0']);
$this->migrator->add('prevention.weeks', 8);
}
};

View File

@ -1,5 +1,5 @@
@component('mail::message')
# Hallo {{ $preventable->member->fullname }},
# Hallo {{ $preventable->getMailRecipient()->name }},
<x-mail-view::editor :content="$bodyText->toArray()['blocks']"></x-mail-view::editor>

View File

@ -13,14 +13,13 @@ use App\Lib\Editor\Condition;
use App\Prevention\Mails\PreventionRememberMail;
use App\Member\Member;
use App\Member\Membership;
use App\Prevention\Actions\YearlyRememberAction;
use App\Prevention\Mails\YearlyMail;
use App\Prevention\PreventionSettings;
use Generator;
use Illuminate\Foundation\Testing\DatabaseTransactions;
use Illuminate\Support\Facades\Mail;
use PHPUnit\Framework\Attributes\DataProvider;
use Tests\Lib\CreatesFormFields;
use Tests\RequestFactories\EditorRequestFactory;
use Tests\TestCase;
uses(DatabaseTransactions::class);
uses(CreatesFormFields::class);
@ -43,7 +42,17 @@ function createParticipant(Form $form): Participant
])->for(Member::factory()->defaults()->has(Membership::factory()->inLocal('€ LeiterIn', 'Wölfling')))->create();
}
function createMember(array $attributes): Member
{
return Member::factory()->defaults()->has(Membership::factory()->inLocal('€ LeiterIn', 'Wölfling'))->create($attributes);
}
dataset('attributes', fn() => [
[
['has_vk' => false, 'efz' => null, 'ps_at' => null],
[Prevention::EFZ, Prevention::VK, Prevention::PS]
],
[
['has_vk' => true, 'efz' => null, 'ps_at' => now()],
[Prevention::EFZ]
@ -174,7 +183,7 @@ it('testItDoesntRememberWhenParticipantDoesntHaveMember', function () {
$this->assertNull($participant->fresh()->last_remembered_at);
});
it('testItRemembersNonLeaders', function () {
it('doesnt remember non leaders', function () {
Mail::fake();
$form = createForm();
$participant = createParticipant($form);
@ -186,7 +195,7 @@ it('testItRemembersNonLeaders', function () {
});
it('testItRemembersMember', function ($attrs, $preventions) {
it('remembers event participant', function ($attrs, $preventions) {
Mail::fake();
$form = createForm();
$participant = createParticipant($form);
@ -195,7 +204,7 @@ it('testItRemembersMember', function ($attrs, $preventions) {
PreventionRememberAction::run();
if (count($preventions)) {
Mail::assertSent(PreventionRememberMail::class, fn($mail) => $mail->preventable->preventions() === $preventions);
Mail::assertSent(PreventionRememberMail::class, fn($mail) => $mail->preventable->preventions()->pluck('type')->toArray() === $preventions);
$this->assertNotNull($participant->fresh()->last_remembered_at);
} else {
Mail::assertNotSent(PreventionRememberMail::class);
@ -203,6 +212,49 @@ it('testItRemembersMember', function ($attrs, $preventions) {
}
})->with('attributes');
it('sets due date in mail when not now', function () {
Mail::fake();
$form = createForm();
$form->update(['from' => now()->addMonths(8)]);
$participant = createParticipant($form);
$participant->member->update(['efz' => now()->subYears(5)->addMonth(), 'ps_at' => now(), 'has_vk' => true]);
PreventionRememberAction::run();
Mail::assertSent(PreventionRememberMail::class, fn($mail) => $mail->preventable->preventions()->first()->expires->isSameDay(now()->addMonth()));
});
it('notices a few weeks before', function ($date, bool $shouldSend) {
Mail::fake();
app(PreventionSettings::class)->fill(['weeks' => 2])->save();
createMember(['efz' => $date, 'ps_at' => now(), 'has_vk' => true]);
YearlyRememberAction::run();
$shouldSend
? Mail::assertSent(YearlyMail::class, fn($mail) => $mail->preventions->first()->expires->isSameDay(now()->addWeeks(2)))
: Mail::assertNotSent(YearlyMail::class);
})->with([
[fn() => now()->subYears(5)->addWeeks(2), true],
[fn() => now()->subYears(5)->addWeeks(2)->addDay(), false],
[fn() => now()->subYears(5)->addWeeks(2)->subDay(), false],
]);
it('remembers members yearly', function ($date, $shouldSend) {
Mail::fake();
createMember(['efz' => $date, 'ps_at' => now(), 'has_vk' => true]);
YearlyRememberAction::run();
$shouldSend
? Mail::assertSent(YearlyMail::class, fn($mail) => $mail->preventions->first()->expires->isSameDay(now()))
: Mail::assertNotSent(YearlyMail::class);
})->with([
[fn() => now()->subYears(5), true],
[fn() => now()->subYears(5)->addDay(), false],
[fn() => now()->subYears(5)->subDay(), false],
]);
it('testItDoesntRememberParticipantThatHasNoMail', function () {
Mail::fake();
$form = createForm();
@ -214,16 +266,6 @@ it('testItDoesntRememberParticipantThatHasNoMail', function () {
Mail::assertNotSent(PreventionRememberMail::class);
});
it('testItRendersMail', function () {
InvoiceSettings::fake(['from_long' => 'Stamm Beispiel']);
$form = createForm();
$participant = createParticipant($form);
(new PreventionRememberMail($participant, app(PreventionSettings::class)->formmail))
->assertSeeInText($participant->member->firstname)
->assertSeeInText($participant->member->lastname)
->assertSeeInText('Stamm Beispiel');
});
it('testItRendersSetttingMail', function () {
Mail::fake();
app(PreventionSettings::class)->fill([
@ -273,10 +315,30 @@ it('testItDoesntAppendTextTwice', function () {
Mail::assertSent(PreventionRememberMail::class, fn($mail) => $mail->bodyText->hasAll(['oberhausen']) && !$mail->bodyText->hasAll(['siegburg']));
});
it('testItDisplaysBodyTextInMail', function () {
/* ----------------------------------------- Mail contents ----------------------------------------- */
it('displays body text in prevention remember mail', function () {
$form = createForm();
$participant = createParticipant($form);
$mail = new PreventionRememberMail($participant, EditorRequestFactory::new()->paragraphs(['ggtt'])->toData());
$mail->assertSeeInText('ggtt');
});
it('renders prevention mail for events with group name', function () {
InvoiceSettings::fake(['from_long' => 'Stamm Beispiel']);
$form = createForm();
$participant = createParticipant($form);
(new PreventionRememberMail($participant, app(PreventionSettings::class)->formmail, collect([])))
->assertSeeInText('Max')
->assertSeeInText('Muster')
->assertSeeInText('Stamm Beispiel');
});
it('renders yearly mail', function () {
InvoiceSettings::fake(['from_long' => 'Stamm Beispiel']);
$member = createMember([]);
$mail = new YearlyMail($member, EditorRequestFactory::new()->paragraphs(['ggtt'])->toData(), collect([]));
$mail
->assertSeeInText('ggtt')
->assertSeeInText('Stamm Beispiel');
});

View File

@ -5,36 +5,34 @@ namespace Tests\Feature\Prevention;
use App\Prevention\PreventionSettings;
use Illuminate\Foundation\Testing\DatabaseTransactions;
use Tests\RequestFactories\EditorRequestFactory;
use Tests\TestCase;
class SettingTest extends TestCase
{
uses(DatabaseTransactions::class);
use DatabaseTransactions;
it('testItOpensSettingsPage', function () {
test()->withoutExceptionHandling();
test()->login()->loginNami();
public function testItOpensSettingsPage(): void
{
$this->login()->loginNami();
test()->get('/setting/prevention')->assertComponent('setting/Prevention')->assertOk();
});
$this->get('/setting/prevention')->assertComponent('setting/Prevention')->assertOk();
}
it('receives settings', function () {
test()->login()->loginNami();
public function testItReceivesSettings(): void
{
$this->login()->loginNami();
$text = EditorRequestFactory::new()->text(50, 'lorem ipsum')->toData();
$yearlyMail = EditorRequestFactory::new()->text(50, 'lala dd')->toData();
app(PreventionSettings::class)->fill(['formmail' => $text, 'yearlymail' => $yearlyMail])->save();
$text = EditorRequestFactory::new()->text(50, 'lorem ipsum')->toData();
app(PreventionSettings::class)->fill(['formmail' => $text])->save();
test()->get('/api/prevention')
->assertJsonPath('data.formmail.blocks.0.data.text', 'lorem ipsum')
->assertJsonPath('data.yearlymail.blocks.0.data.text', 'lala dd');
});
$this->get('/api/prevention')
->assertJsonPath('data.formmail.blocks.0.data.text', 'lorem ipsum');
}
it('testItStoresSettings', function () {
test()->login()->loginNami();
public function testItStoresSettings(): void
{
$this->login()->loginNami();
$this->post('/api/prevention', ['formmail' => EditorRequestFactory::new()->text(50, 'new lorem')->create()])->assertOk();
$this->assertTrue(app(PreventionSettings::class)->formmail->hasAll(['new lorem']));
}
}
$formmail = EditorRequestFactory::new()->text(50, 'new lorem')->create();
$yearlyMail = EditorRequestFactory::new()->text(50, 'lala dd')->create();
test()->post('/api/prevention', ['formmail' => $formmail, 'yearlymail' => $yearlyMail])->assertOk();
test()->assertTrue(app(PreventionSettings::class)->formmail->hasAll(['new lorem']));
test()->assertTrue(app(PreventionSettings::class)->yearlymail->hasAll(['lala dd']));
});